Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pipelines sync-status command flags handling #2095

Merged
merged 3 commits into from
Jul 30, 2023
Merged

Fix pipelines sync-status command flags handling #2095

merged 3 commits into from
Jul 30, 2023

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Jul 23, 2023 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Make repository and branch flags not optional, and raise errors when they are not provided.

@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jul 23, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 23, 2023
@eyalbe4 eyalbe4 added the bug Something isn't working label Jul 30, 2023
eyalbe4
eyalbe4 requested changes Jul 30, 2023
View reviewed changes
pipelines/cli.go Outdated Show resolved Hide resolved
pipelines/cli.go Outdated Show resolved Hide resolved
utils/cliutils/commandsflags.go Outdated Show resolved Hide resolved
utils/cliutils/commandsflags.go Outdated Show resolved Hide resolved
@sverdlov93 sverdlov93 merged commit 0c944d8 into jfrog:dev Jul 30, 2023
9 of 10 checks passed
@chenrui333 chenrui333 mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

@bhanurp bhanurp Awaiting requested review from bhanurp

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @eyalbe4